[PATCH] D34769: [X86] X86::CMOV to Branch heuristic based optimization

[Amjad Aboud via Phabricator via llvm-commits]

aaboud added inline comments.


================
Comment at: lib/Target/X86/X86CmovConversion.cpp:564
+  // destination registers, and the registers that went into the PHI.
+  DenseMap<unsigned, std::pair<unsigned, unsigned>> RegRewriteTable;
+
----------------
zvi wrote:
> Please add comment explaining the data-structure
There is a comment explaining this map and even explaining the motivation behind it:

```
  //  ...   and that the code must maintain a mapping from earlier PHI's
  // destination registers, and the registers that went into the PHI.
```


https://reviews.llvm.org/D34769