[PATCH] D35303: [X86][SSE] Add pre-AVX2 support for (i32 bitcast(v32i1)) -> 2xMOVMSK

[Filipe Cabecinhas via Phabricator via llvm-commits]

filcab added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:29284
+    return DAG.getZExtOrTrunc(V, DL, VT);
+  } else if (SExtVT == MVT::v8i16) {
     V = DAG.getBitcast(MVT::v16i8, V);
----------------
Suggestion: We can probably split the `else if`, as I think it makes it easy to miss that the block above already returned. What do you think about:
```
if (SextVT == MVT::v32i8 && ...) {
  //...
  return ...
}

if (SExtVT == MVT::v8i16) {
  ...
```


Repository:
  rL LLVM

https://reviews.llvm.org/D35303