[PATCH] D34753: [Support] - Add bad alloc error handler for handling allocation malfunctions

Klaus Kretzschmar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 01:00:39 PDT 2017


kkretzsch added a comment.

In https://reviews.llvm.org/D34753#805362, @rnk wrote:

> I made some minor modifications. Taking the revision to upload them so you can see them.


Thanks for commiting my change. One comment on your changes. The reason why I changed the fallback behavior to calling an assertion instead of  the report_fatal_error function was that 'report_fatal_error' itself does some allocation, e.g. constucts a  MutexGuard.  This is problematic in an OOM situation.


Repository:
  rL LLVM

https://reviews.llvm.org/D34753





More information about the llvm-commits mailing list