[PATCH] D35282: [Dominators] Split SemiNCA into smaller functions

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 21:38:01 PDT 2017


kuhar added inline comments.


================
Comment at: include/llvm/Support/GenericDomTreeConstruction.h:34
+#define DTB_DEBUG_TYPE "dom-tree-builder"
+#define DTB_DEBUG(Arg) DEBUG_WITH_TYPE(DTB_DEBUG_TYPE, Arg)
+
----------------
dberlin wrote:
> Why doesn't #define DEBUG_TYPE work?
The macro can clash with DEBUG_TYPE in a file including it. Is it better change it to DEBUG_TYPE and undef it at the bottom of this header?


https://reviews.llvm.org/D35282





More information about the llvm-commits mailing list