[PATCH] D35286: [Dominators] Simplify block and node printing

[Daniel Berlin via Phabricator via llvm-commits]

dberlin added inline comments.


================
Comment at: include/llvm/Support/GenericDomTreeConstruction.h:103
 
+  struct BlockPrinter {
+    NodePtr N;
----------------
This doesn't print blocks, it print block names.
I'd go with BlockNamePrinter.



================
Comment at: include/llvm/Support/GenericDomTreeConstruction.h:298
       NodePtr W = NumToNode[i];
-      DTB_DEBUG(dbgs() << "\tdiscovereed a new reachable node ");
-      DTB_DEBUG(PrintBlockOrNullptr(dbgs(), W));
-      DTB_DEBUG(dbgs() << "\n");
+      DTB_DEBUG(dbgs() << "\tdiscovereed a new reachable node "
+                       << BlockPrinter(W) << "\n");
----------------
typo: discovereed->discovered


https://reviews.llvm.org/D35286