[PATCH] D34690: [LLD][ELF] Introduce target specific inBranchRange() function

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 19:02:27 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/Arch/ARM.cpp:227
 
+bool ARM::inBranchRange(uint32_t RelocType, uint64_t Src, uint64_t Dst) const {
+  uint64_t Range;
----------------
In this function, you computed the exact distance between two instructions, but does this much preciseness actually needed? A few bytes difference seems negligible when you want to know whether two instructions are in +-16MiB, for example.


https://reviews.llvm.org/D34690





More information about the llvm-commits mailing list