[PATCH] D33880: COFF: Introduce LD shim around LINK

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/include/lld/Driver/Driver.h:21
+bool ldshim(llvm::ArrayRef<const char *> Args,
+          llvm::raw_ostream &Diag = llvm::errs());
 }
----------------
Indentation. Please use clang-format-diff before sending patches so that human reviewers can focus on meaning of the code instead of formatting.


================
Comment at: lld/lib/Shim/COFFLdShim.cpp:1
+//===- lib/Driver/COFFLdShim.cpp ------------------------------------------===//
+//
----------------
ruiu wrote:
> martell wrote:
> > Location Okay?
> See the comment above.
> 
> Rename this file `MingwDriver.cpp`.
Please move this file as I wrote above.


Repository:
  rL LLVM

https://reviews.llvm.org/D33880