[PATCH] D34692: [LLD][ELF] Add support for multiple passes to createThunks()

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 16:45:08 PDT 2017


ruiu added a comment.

This is getting a bit tricky. I think creating thunks is by nature a bit tricky, so it is perhaps unavoidable, but I think writing a document (or a document style comment) that describes the overview of the thunk creation would help. My file comment in https://github.com/llvm-project/llvm-project-20170507/blob/master/lld/ELF/ICF.cpp is an example. The other example is https://github.com/llvm-project/llvm-project-20170507/blob/master/lld/ELF/Threads.h.


https://reviews.llvm.org/D34692





More information about the llvm-commits mailing list