[PATCH] D34863: [XRay][tools] Function call stack based analysis tooling for XRay traces

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added a comment.

In https://reviews.llvm.org/D34863#805704, @kpw wrote:

> Sorry for the delay getting comments on this. My phabricator email address lapsed into an unvalidated state and I haven't been getting messages until today.
>
> Thanks for getting a start on this. The trie data structure looks very analogous to the Chrome Trace Viewer format given some scheme to generate stack ids like FnId->FnId->FnId.
>
> I can pick this up and play with it, using StackTrie within llvm-xray convert. We have a sync later this afternoon, but the moral of the story is that I'll integrate this into my tree and make the changes from my comments to get started.
>  Would you like me to "Commandeer the revision" once I have some edits?


Yes, please! Feel free to take over the revision, happy to be a reviewer on the side for this (given the other things I'm working on). :)


https://reviews.llvm.org/D34863