[PATCH] D35006: [AArch64] Implement support for windows style vararg functions

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 14:12:23 PDT 2017


rnk added inline comments.


================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:4591-4593
+  if (Subtarget->isTargetWindows())
+    return LowerWin64_VASTART(Op, DAG);
   return Subtarget->isTargetDarwin() ? LowerDarwin_VASTART(Op, DAG)
----------------
IMO it would be nice to make this match with two ifs. Now that we have 3 cases, the old ternary conditional doesn't look right.


https://reviews.llvm.org/D35006





More information about the llvm-commits mailing list