[PATCH] D35163: [PDB] Enable NativeSession to create symbols for built-in types on demand

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 13:31:43 PDT 2017


amccarth added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/PDB/Native/NativeSession.h:13
 
+#include <unordered_map>
+
----------------
zturner wrote:
> Can you use `llvm::DenseMap` instead (and delete this `#include`)
Sure, but the TypeIndexToSymbolId map won't be dense in most cases.  There will likely be a relatively small number of entries with scattered key values.  What (where?) are the guidelines for when to use DenseMap?


https://reviews.llvm.org/D35163





More information about the llvm-commits mailing list