[PATCH] D35135: Refactor MemoryMappingLayout::Next to use a single struct instead of output parameters. NFC.

[Francis Ricci via Phabricator via llvm-commits]

fjricci added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_procmaps.h:86
+  void GetSegmentAddrRange(MemoryMappedSegment *segment, uptr vmaddr,
+                           uptr vmsize);
   int current_image_;
----------------
alekseyshl wrote:
> Nit: what would you say about moving output parameter to be the last one and renaming function to Set...?
> 
>   void SetSegmentAddrRange(uptr vmaddr, uptr vmsize, MemoryMappedSegment *segment);
> 
> Also, it's not that big, it is called from one place only, maybe just inline it? We do not have GetSegmentFileName and such after all.
Addressed this in a follow-up commit: D35270


https://reviews.llvm.org/D35135