[PATCH] D35207: [ELF] - Give a symbol version extracted from name a priority over version set by script.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/SymbolTable.cpp:705
     Symbol *Sym = B->symbol();
     if (Sym->InVersionScript)
       warn("duplicate symbol '" + Ver.Name + "' in version script");
----------------
Can you replace this with

  if (Sym->VersionId != Config->DefaultSymbolVersion)

to remove `Symbol::InVersionScript`?


================
Comment at: ELF/SymbolTable.cpp:756
+  for (Symbol *Sym : SymVector)
+      Sym->body()->parseSymbolVersion();
 }
----------------
Indentation


https://reviews.llvm.org/D35207