[PATCH] D34619: [ARM] Enable partial and runtime unrolling

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 10:50:38 PDT 2017


efriedma added inline comments.


================
Comment at: test/CodeGen/ARM/loop-unrolling.ll:1
+; RUN: opt -mcpu=cortex-m4 -loop-unroll -S %s -o - | FileCheck %s
+
----------------
We usually put tests for IR transforms into test/Transforms/; for unrolling in particular, that would be something like test/Transforms/LoopUnroll/ARM/ (you'll have to create a new directory, and make a lit.local.cfg so the test is only enabled if we have an ARM target).

And I'd like to see some basic test to show that this doesn't change the unroll heuristics on, for example, cortex-a57 (where BasicTTIImplBase::getUnrollingPreferences currently changes the unroll threshold).


https://reviews.llvm.org/D34619





More information about the llvm-commits mailing list