[PATCH] D35163: [PDB] Enable NativeSession to create symbols for built-in types on demand
Zachary Turner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 11 10:28:18 PDT 2017
zturner added inline comments.
================
Comment at: llvm/lib/DebugInfo/PDB/Native/NativeSession.cpp:114-115
+ const codeview::TypeIndex TI(Index);
+ if (TI.getSimpleMode() != codeview::SimpleTypeMode::Direct)
+ return 0;
+ const auto Kind = TI.getSimpleKind();
----------------
Can you add a fixme to handle this? Simple Types include things like pointers to other simple types, which we'll need to handle.
https://reviews.llvm.org/D35163
More information about the llvm-commits
mailing list