[PATCH] D35168: [mips] Handle the `long-calls` feature flags in the MIPS backend

[Simon Dardis via Phabricator via llvm-commits]

sdardis added a comment.

2 nits: We should warn/error in LLVM on mixing abicalls and long calls (abicalls overrides long calls). We should make sure clang warns but doesn't error.

Second is about 64bit support, inlined,



================
Comment at: lib/Target/Mips/MipsISelLowering.cpp:3024
 
+  if (Subtarget.useLongCalls() && Subtarget.hasSym32() && !IsPIC) {
+    // Get the address of the callee into a register to prevent
----------------
Nit:// FIXME: Add support for 64 bit symbols.


Repository:
  rL LLVM

https://reviews.llvm.org/D35168