[PATCH] D35249: [mips][mt][2/7] Implement .module and .set directives for the MT ASE.

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/MC/Mips/mt/module-directive.s:2
+# RUN: llvm-mc < %s -arch=mips -mcpu=mips32r2 -filetype=obj -o - | \
+# RUN:   llvm-objdump -D - | FileCheck --check-prefix=CHECK-OBJ %s
+# RUN: llvm-mc < %s -arch=mips -mcpu=mips32r2 -filetype=asm -o - | \
----------------
I would try to use `llvm-readobj -mips-abi-flags` to check the .MIPS.abiflags section content.


================
Comment at: test/MC/Mips/mt/set-directive.s:2
+# RUN: llvm-mc < %s -arch=mips -mcpu=mips32r2 -filetype=obj -o - | \
+# RUN:   llvm-objdump -D - | FileCheck %s --check-prefix=CHECK-OBJ
+# RUN: llvm-mc < %s -arch=mips -mcpu=mips32r2 -filetype=asm -o - | \
----------------
and ditto here.


https://reviews.llvm.org/D35249