[PATCH] D34345: [LLD][ELF] Extract temporary state used in assignAddresses()

Peter Smith via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 02:32:18 PDT 2017


Thanks for pointing that out, I've added a comment in both locations
(r307637) to explain why it is there, there is already a comment in
the header file.

There is also some more context in the llvm-commits mail thread on
D34345 than will have made it to phabricator that discusses it.

Peter

On 11 July 2017 at 00:21, Mehdi AMINI via Phabricator
<reviews at reviews.llvm.org> wrote:
> mehdi_amini added inline comments.
>
>
> ================
> Comment at: lld/trunk/ELF/LinkerScript.cpp:846
> +  auto State = make_unique<AddressState>(Opt);
> +  CurAddressState = State.get();
>    ErrorOnMissingSection = true;
> ----------------
> Same here actually
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D34345
>
>
>


More information about the llvm-commits mailing list