[PATCH] D35098: [asan] For iOS/AArch64, if the dynamic shadow doesn't fit, restrict the VM space

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 14:06:40 PDT 2017


vitalybuka added a comment.

LGTM



================
Comment at: lib/asan/asan_linux.cc:80
 
+uptr FindDynamicShadowStart() {
+  UNREACHABLE("FindDynamicShadowStart is not available");
----------------
vitalybuka wrote:
> Maybe it's better to not define function at all and trigger linking error?
Please ignore this, I see this is called from branch which should not be executed on linux.


https://reviews.llvm.org/D35098





More information about the llvm-commits mailing list