[PATCH] D35152: Add some basic linker module symbols

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: lld/COFF/Driver.cpp:59
   Config = make<Configuration>();
+  Config->Argv.assign(Args.begin(), Args.end());
   Config->ColorDiagnostics =
----------------
I honestly didn't know that std::vector has `assign` member function. Does

  Config->Argv = {Args.begin(), Args.end()};

work too? If so, I prefer this way.


================
Comment at: lld/ELF/Config.h:107
   std::vector<uint8_t> BuildIdVector;
+  std::vector<llvm::StringRef> Argv;
   llvm::MapVector<Symbol *, RenamedSymbol> RenamedSymbols;
----------------
Move this before `AuxiliaryList`.


https://reviews.llvm.org/D35152