[PATCH] D34964: [LLD] [COFF] Add initial support for some ARM64 relocations and import thunks

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: COFF/Chunks.cpp:388-389
 
+void ImportThunkChunkARM64::getBaserels(std::vector<Baserel> *Res) {
+}
+
----------------
ruiu wrote:
> Is this a to-do, or really empty?
I think it's ok to leave it empty; the instructions in the import thunk load the actual target address using position independent addressing. I've tested this with wine, with the exe loaded at a different address than the base address, and they run fine.


https://reviews.llvm.org/D34964