[PATCH] D35152: Add some basic linker module symbols

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/COFF/Error.h:21
 extern llvm::raw_ostream *ErrorOS;
-extern llvm::StringRef Argv0;
 
----------------
zturner wrote:
> ruiu wrote:
> > Sorry for the last-minute comment, but can you keep this variable and just change it stype from llvm::StringRef to std::vector<llvm::StringRef> to make it consistent with ELF? I don't want to make them being diverged too much.
> Is it ok to have a global `std::vector`?  This might invoke an undesirable global constructor.
Well, it might not be desirable, but we already have a few global std::vectors.


https://reviews.llvm.org/D35152