[PATCH] D35152: Add some basic linker module symbols

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 13:21:04 PDT 2017


ruiu added inline comments.


================
Comment at: lld/COFF/Error.h:21
 extern llvm::raw_ostream *ErrorOS;
-extern llvm::StringRef Argv0;
 
----------------
Sorry for the last-minute comment, but can you keep this variable and just change it stype from llvm::StringRef to std::vector<llvm::StringRef> to make it consistent with ELF? I don't want to make them being diverged too much.


https://reviews.llvm.org/D35152





More information about the llvm-commits mailing list