[PATCH] D35213: [WebAssembly] Be consistent in generating trivial test input files

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 13:20:53 PDT 2017


dschuff accepted this revision.
dschuff added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/Object/Inputs/trivial.ll:1
+; llc -mtriple=wasm32-unknown-unknown-wasm trivial.ll -filetype=obj -o trivial-object-test.wasm
+
----------------
This looks like it's supposed to be a RUN line but of course it's not. So maybe just put an explanatory comment before this line that says something like 'to regenerate the trivial-object.wasm file, run the following command.'


================
Comment at: test/tools/llvm-objdump/Inputs/trivial.ll:1
+; llc -mtriple=wasm32-unknown-unknown-wasm trivial.ll -filetype=obj -o trivial.obj.wasm
+
----------------
and ditto here.


https://reviews.llvm.org/D35213





More information about the llvm-commits mailing list