ruiu accepted this revision. ruiu added a comment. This revision is now accepted and ready to land. LGTM ================ Comment at: lld/COFF/Config.h:95 llvm::SmallString<128> PDBPath; + std::vector<StringRef> Argv; ---------------- This can be ArrayRef. https://reviews.llvm.org/D35152