[compiler-rt] r307577 - Do not crash with missing symbolication when running in DEDUP mode

George Karpenkov via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 13:06:07 PDT 2017


Author: george.karpenkov
Date: Mon Jul 10 13:06:06 2017
New Revision: 307577

URL: http://llvm.org/viewvc/llvm-project?rev=307577&view=rev
Log:
Do not crash with missing symbolication when running in DEDUP mode

Printing stacktrace from ASAN crashes with a segfault in DEDUP mode when
symbolication is missing.

Differential Revision: https://reviews.llvm.org/D34914

Modified:
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_libcdep.cc

Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_libcdep.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_libcdep.cc?rev=307577&r1=307576&r2=307577&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_libcdep.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_libcdep.cc Mon Jul 10 13:06:06 2017
@@ -43,7 +43,8 @@ void StackTrace::Print() const {
       if (dedup_frames-- > 0) {
         if (dedup_token.length())
           dedup_token.append("--");
-        dedup_token.append(cur->info.function);
+        if (cur->info.function != nullptr)
+          dedup_token.append(cur->info.function);
       }
     }
     frames->ClearAll();




More information about the llvm-commits mailing list