[PATCH] D35207: [ELF] - Give a symbol version extracted from name a priority over version set by script.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/SymbolTable.cpp:234
     Sym = make<Symbol>();
-    Sym->InVersionScript = false;
+    Sym->GotVersionFromName = false;
     Sym->Binding = STB_WEAK;
----------------
`Got` is in general not a good name in the linker as it could mean Global Offset Table.


================
Comment at: ELF/Symbols.h:366-370
+  // Symbols can have version baked in their names. If flag is true
+  // that means version was set from name, such version has priority
+  // over versions from script.
+  unsigned GotVersionFromName : 1;
 
----------------
Do you really need this? You could just call parseSymbolVersion after processing version scripts, no?


https://reviews.llvm.org/D35207