[PATCH] D35189: Add GUID-ValueID map and original name to ThinLTO summary.

Haojie Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 10:35:16 PDT 2017


haojiewang added a comment.

In https://reviews.llvm.org/D35189#803332, @mehdi_amini wrote:

> The context and the motivation is *still* not clear to me. To begin why do we need the *names* when doing the thin link?


We need the GUID because it is needed when we build the combined index in thin link phase. We need ValueId is because the size of GUID is too large so that we do not want to write it everywhere, so we set a ValueId which is indexing from 0. And we should also set a GUID to ValueId map to record the mapping between them. 
We need the original name because it is needed in FunctionImport. So we should pass is to thin link phase.


https://reviews.llvm.org/D35189





More information about the llvm-commits mailing list