[PATCH] D35134: [tsan] Add comments for the bool argument of ThreadIgnoreBegin/ThreadIgnoreSyncBegin, NFC.
Phabricator via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 10 08:37:59 PDT 2017
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307545: [tsan] Add comments for the bool argument of… (authored by kuba.brecka).
Changed prior to commit:
https://reviews.llvm.org/D35134?vs=105665&id=105859#toc
Repository:
rL LLVM
https://reviews.llvm.org/D35134
Files:
compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc
compiler-rt/trunk/lib/tsan/rtl/tsan_interface_ann.cc
Index: compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc
===================================================================
--- compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc
+++ compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc
@@ -261,7 +261,7 @@
void ScopedInterceptor::EnableIgnores() {
if (ignoring_) {
- ThreadIgnoreBegin(thr_, pc_, false);
+ ThreadIgnoreBegin(thr_, pc_, /*save_stack=*/false);
if (flags()->ignore_noninstrumented_modules) thr_->suppress_reports++;
if (in_ignored_lib_) {
DCHECK(!thr_->in_ignored_lib);
Index: compiler-rt/trunk/lib/tsan/rtl/tsan_interface_ann.cc
===================================================================
--- compiler-rt/trunk/lib/tsan/rtl/tsan_interface_ann.cc
+++ compiler-rt/trunk/lib/tsan/rtl/tsan_interface_ann.cc
@@ -483,8 +483,8 @@
else
MutexPreLock(thr, pc, (uptr)m);
}
- ThreadIgnoreBegin(thr, pc, false);
- ThreadIgnoreSyncBegin(thr, pc, false);
+ ThreadIgnoreBegin(thr, pc, /*save_stack=*/false);
+ ThreadIgnoreSyncBegin(thr, pc, /*save_stack=*/false);
}
INTERFACE_ATTRIBUTE
@@ -510,8 +510,8 @@
} else {
ret = MutexUnlock(thr, pc, (uptr)m, flagz);
}
- ThreadIgnoreBegin(thr, pc, false);
- ThreadIgnoreSyncBegin(thr, pc, false);
+ ThreadIgnoreBegin(thr, pc, /*save_stack=*/false);
+ ThreadIgnoreSyncBegin(thr, pc, /*save_stack=*/false);
return ret;
}
@@ -525,8 +525,8 @@
INTERFACE_ATTRIBUTE
void __tsan_mutex_pre_signal(void *addr, unsigned flagz) {
SCOPED_ANNOTATION(__tsan_mutex_pre_signal);
- ThreadIgnoreBegin(thr, pc, false);
- ThreadIgnoreSyncBegin(thr, pc, false);
+ ThreadIgnoreBegin(thr, pc, /*save_stack=*/false);
+ ThreadIgnoreSyncBegin(thr, pc, /*save_stack=*/false);
}
INTERFACE_ATTRIBUTE
@@ -547,7 +547,7 @@
INTERFACE_ATTRIBUTE
void __tsan_mutex_post_divert(void *addr, unsigned flagz) {
SCOPED_ANNOTATION(__tsan_mutex_post_divert);
- ThreadIgnoreBegin(thr, pc, false);
- ThreadIgnoreSyncBegin(thr, pc, false);
+ ThreadIgnoreBegin(thr, pc, /*save_stack=*/false);
+ ThreadIgnoreSyncBegin(thr, pc, /*save_stack=*/false);
}
} // extern "C"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35134.105859.patch
Type: text/x-patch
Size: 2118 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170710/6ae0e86f/attachment.bin>
More information about the llvm-commits
mailing list