[PATCH] D35199: Add an X86 AVX2 clang builder and slave

[Zvi Rackover via Phabricator via llvm-commits]

zvi added inline comments.


================
Comment at: buildbot/osuosl/master/config/builders.py:634
+        ## X86_64 AVX2 Clang+LLVM check-all + test-suite
+        {'name': "clang-cmake-x86_64-avx2-linux",
+         'slavenames':["avx2-intel64"],
----------------
does the 'clang' component in the machine name mean:

   - We are using Clang to build LLVM and Clanf
or:


  - We are building LLVM + Clang using the Ubuntu default system compiler?






================
Comment at: buildbot/osuosl/master/config/builders.py:638
+         'factory' : ClangBuilder.getClangCMakeBuildFactory(
+             jobs=80,
+             clean=False,
----------------
Given that we are allowing lots of jobs to run in parallel, should we be using Ninja instead of Make? It's known to scale better.


================
Comment at: buildbot/osuosl/master/config/builders.py:1121
                          env={'PATH':'/home/llvmbb/bin/clang-latest/bin:/home/llvmbb/bin:/usr/local/bin:/usr/local/bin:/usr/bin:/bin'})},
-                         
+
         {'name': "libomp-clang-ppc64le-linux-debian",
----------------
Looks like this line + 2 below are only white-space changes.


https://reviews.llvm.org/D35199