[PATCH] D35157: [tsan] Add support for running TSan tests on iOS simulator and devices
Dmitry Vyukov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 10 00:56:56 PDT 2017
dvyukov accepted this revision.
dvyukov added a comment.
This revision is now accepted and ready to land.
LGTM with a nit
================
Comment at: test/tsan/deep_stack1.cc:27
+#define ROUND_UP(N, M) (((N + M - 1) / M) * M)
+
----------------
A function please.
A proper macro would need to put all args into () and use expression blocks and create local copies of args to avoid double evaluation. A function working on size_t will be much simpler.
https://reviews.llvm.org/D35157
More information about the llvm-commits
mailing list