[PATCH] D35154: [tsan] Add a max VM address check for Darwin/AArch64

Dmitry Vyukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 00:52:53 PDT 2017


dvyukov added inline comments.


================
Comment at: lib/tsan/rtl/tsan_platform_mac.cc:235
+  uptr max_vm = GetMaxVirtualAddress() + 1;
+  if (max_vm > kHiAppMemEnd) {
+    CHECK(0 && "vm address limit too high");
----------------
This can provide a better error message without an unnecessary stack trace, but up to you.


  if (max_vm != kHiAppMemEnd) {
    Printf("ThreadSanitizer: unsupported vm address limit %p, expect %p\n", max_vm, kHiAppMemEnd);
    Die();
  }


Repository:
  rL LLVM

https://reviews.llvm.org/D35154





More information about the llvm-commits mailing list