[PATCH] D35134: [tsan] Add comments for the bool argument of ThreadIgnoreBegin/ThreadIgnoreSyncBegin, NFC.

[Dmitry Vyukov via llvm-commits]

On Sun, Jul 9, 2017 at 3:14 PM, Kuba (Brecka) Mracek via Phabricator
<reviews at reviews.llvm.org> wrote:
> kubamracek created this revision.
> kubamracek added a project: Sanitizers.
>
> https://reviews.llvm.org/D35134

/\/\/\/\/\
This link gives me "DNS address could not be found" error. Is it a known issue?

LGTM, Approved


> Files:
>   lib/tsan/rtl/tsan_interceptors.cc
>   lib/tsan/rtl/tsan_interface_ann.cc
>
>
> Index: lib/tsan/rtl/tsan_interface_ann.cc
> ===================================================================
> --- lib/tsan/rtl/tsan_interface_ann.cc
> +++ lib/tsan/rtl/tsan_interface_ann.cc
> @@ -483,8 +483,8 @@
>      else
>        MutexPreLock(thr, pc, (uptr)m);
>    }
> -  ThreadIgnoreBegin(thr, pc, false);
> -  ThreadIgnoreSyncBegin(thr, pc, false);
> +  ThreadIgnoreBegin(thr, pc, /*save_stack=*/false);
> +  ThreadIgnoreSyncBegin(thr, pc, /*save_stack=*/false);
>  }
>
>  INTERFACE_ATTRIBUTE
> @@ -510,8 +510,8 @@
>    } else {
>      ret = MutexUnlock(thr, pc, (uptr)m, flagz);
>    }
> -  ThreadIgnoreBegin(thr, pc, false);
> -  ThreadIgnoreSyncBegin(thr, pc, false);
> +  ThreadIgnoreBegin(thr, pc, /*save_stack=*/false);
> +  ThreadIgnoreSyncBegin(thr, pc, /*save_stack=*/false);
>    return ret;
>  }
>
> @@ -525,8 +525,8 @@
>  INTERFACE_ATTRIBUTE
>  void __tsan_mutex_pre_signal(void *addr, unsigned flagz) {
>    SCOPED_ANNOTATION(__tsan_mutex_pre_signal);
> -  ThreadIgnoreBegin(thr, pc, false);
> -  ThreadIgnoreSyncBegin(thr, pc, false);
> +  ThreadIgnoreBegin(thr, pc, /*save_stack=*/false);
> +  ThreadIgnoreSyncBegin(thr, pc, /*save_stack=*/false);
>  }
>
>  INTERFACE_ATTRIBUTE
> @@ -547,7 +547,7 @@
>  INTERFACE_ATTRIBUTE
>  void __tsan_mutex_post_divert(void *addr, unsigned flagz) {
>    SCOPED_ANNOTATION(__tsan_mutex_post_divert);
> -  ThreadIgnoreBegin(thr, pc, false);
> -  ThreadIgnoreSyncBegin(thr, pc, false);
> +  ThreadIgnoreBegin(thr, pc, /*save_stack=*/false);
> +  ThreadIgnoreSyncBegin(thr, pc, /*save_stack=*/false);
>  }
>  }  // extern "C"
> Index: lib/tsan/rtl/tsan_interceptors.cc
> ===================================================================
> --- lib/tsan/rtl/tsan_interceptors.cc
> +++ lib/tsan/rtl/tsan_interceptors.cc
> @@ -261,7 +261,7 @@
>
>  void ScopedInterceptor::EnableIgnores() {
>    if (ignoring_) {
> -    ThreadIgnoreBegin(thr_, pc_, false);
> +    ThreadIgnoreBegin(thr_, pc_, /*save_stack=*/false);
>      if (flags()->ignore_noninstrumented_modules) thr_->suppress_reports++;
>      if (in_ignored_lib_) {
>        DCHECK(!thr_->in_ignored_lib);
>
>