[PATCH] D35096: Increase the import-threshold for crtical functions.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 9 19:54:12 PDT 2017


mehdi_amini added a comment.

Missing test showing the import happening on critical and not without. Right now the test you provided only shows that the "critical" flag is encoded in the binary. The change in the function importer is not tested, unless I missed something.



================
Comment at: include/llvm/IR/ModuleSummaryIndex.h:56
+    Critical = 4
+  };
   HotnessType Hotness = HotnessType::Unknown;
----------------
Some documentation on Critical at this level could be nice.


https://reviews.llvm.org/D35096





More information about the llvm-commits mailing list