[PATCH] D35142: WIP! [CFG] Create a new removeUnreachable utility that updates the dom in place

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 9 08:32:20 PDT 2017


dberlin added inline comments.


================
Comment at: lib/Transforms/Utils/Local.cpp:1711
+  for (BasicBlock *BB : RPOT)
+    Live.insert(BB);
+
----------------
Note that if the dom tree is up to date, it would suffice to do:

for (auto *BB : nodes(DT))
  Live.insert(BB->getBlock())

or whatever

But IIRC, in your case, the dominator tree is *not* up to date, right?




https://reviews.llvm.org/D35142





More information about the llvm-commits mailing list