[PATCH] D34520: Minor correctness improvements for LLVMTestingSupport

[NAKAMURA Takumi via Phabricator via llvm-commits]

chapuni added inline comments.


================
Comment at: llvm/lib/CMakeLists.txt:33
+endif()
\ No newline at end of file

----------------
Could you add linefeed at eof?


================
Comment at: llvm/lib/Testing/Support/CMakeLists.txt:12
 include_directories(${LLVM_MAIN_SRC_DIR}/utils/unittest/googlemock/include)
-target_link_libraries(LLVMTestingSupport PRIVATE gtest)
\ No newline at end of file
+target_link_libraries(LLVMTestingSupport INTERFACE gtest)
----------------
In general, I recommend;
INTERFACE in static library
PRIVATE in SHARED library (BUILD_SHARED_LIBS=ON)

llvm_add_library(LINK_LIBS) does.


https://reviews.llvm.org/D34520