[PATCH] D33760: [libunwind][CMake] Add install path variable to allow overriding the destination

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 7 10:10:07 PDT 2017


beanz added inline comments.


================
Comment at: CMakeLists.txt:167
 
+set(LIBUNWIND_INSTALL_PREFIX "" CACHE STRING
+    "Define libunwind destination prefix.")
----------------
We need to have some enforcement that this is either empty or ends in "/" otherwise the behavior will be unintuitive. If you add that to all three of the patches this will be good.

That enforcement could be something like I sent you a while back, or it could be a CMake error. I just want to make it hard to misuse this feature.


Repository:
  rL LLVM

https://reviews.llvm.org/D33760





More information about the llvm-commits mailing list