[PATCH] D35092: Use native path syntax when writing PDB module name.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lld/COFF/PDB.cpp:248-249
     SmallString<128> Path = InArchive ? File->ParentName : File->getName();
+    sys::path::native(Path);
     sys::fs::make_absolute(Path);
     StringRef Name = InArchive ? File->getName() : StringRef(Path);
----------------
We should explicitly pass sys::fs::style::windows to get the same behavior on Linux, right? Otherwise the test won't pass there.


================
Comment at: lld/test/COFF/pdb-diff.test:175
 CHECK-NEXT:   |----------------------------------------+---|
-CHECK-NEXT:   |Module "D:\src\llvm-mono\lld\test\COFF/Inputs/pdb-diff.obj"|
+CHECK-NEXT:   |Module "D:\src\llvm-mono\lld\test\coff\Inputs\pdb-diff.obj"|
+CHECK-NEXT:   |----------------------------------------+---|
----------------
This absolute path won't be the same on other people's systems.


https://reviews.llvm.org/D35092