[PATCH] D35116: [ARM] Tidy up ARMBaseRegisterInfo implementation. NFC

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 7 05:28:00 PDT 2017


rovka added a comment.

Actually, I do have one nit :)



================
Comment at: lib/Target/ARM/ARMBaseRegisterInfo.cpp:199
+    for (MCSubRegIterator SI(Reg, this); SI.isValid(); ++SI)
+      if (Reserved.test(*SI)) markSuperRegs(Reserved, Reg);
 
----------------
While you're at it, you could also move markSuperRegs on its own line, it looks weird like this.


https://reviews.llvm.org/D35116





More information about the llvm-commits mailing list