[llvm] r307058 - [Orc] Remove the memory manager argument to addModule, and de-templatize the

[Andres Freund via llvm-commits]

Hi,

On 2017-07-04 04:42:30 -0000, Lang Hames via llvm-commits wrote:>  
>      auto LO =
> -      createLinkedObject(std::move(Obj), std::move(MemMgr), std::move(Resolver),
> -                         std::move(Finalizer), ProcessAllSections);
> +      createLinkedObject(std::move(Obj), GetMemMgr(),
> +                         std::move(Resolver), std::move(Finalizer),
> +                         ProcessAllSections);
> Modified: llvm/trunk/lib/ExecutionEngine/Orc/OrcCBindingsStack.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/Orc/OrcCBindingsStack.h?rev=307058&r1=307057&r2=307058&view=diff
> ==============================================================================
> --- llvm/trunk/lib/ExecutionEngine/Orc/OrcCBindingsStack.h (original)
> +++ llvm/trunk/lib/ExecutionEngine/Orc/OrcCBindingsStack.h Mon Jul  3 21:42:30 2017
> @@ -105,6 +105,10 @@ public:
>                      IndirectStubsManagerBuilder IndirectStubsMgrBuilder)
>        : DL(TM.createDataLayout()), IndirectStubsMgr(IndirectStubsMgrBuilder()),
>          CCMgr(std::move(CCMgr)),
> +        ObjectLayer(
> +          []() {
> +            return std::make_shared<SectionMemoryManager>();
> +          }),

Doesn't this mean we'll, at least if GetMemMgr() returns a new mmgr as
the case in the OrcC stack, create a new mmgr for every object? That
seems suboptimal?

- Andres