[PATCH] D35099: Add name offset flags, for parity with cvtres.exe.

[Eric Beckmann via Phabricator via llvm-commits]

ecbeckmann created this revision.
Herald added a subscriber: hiraditya.

The original cvtres.exe sets the high bit when an identifier offset
points to a string.  Even though this is not mentioned in the spec, and
in fact does not seem to cause errors with most cases, for some reason
this causes a failure in Chromium where the new resource file is not
verified as a new version.  This patch sets this high bit flag, and also
adds a test case to check that the output of our library is always
identical to original cvtres.


https://reviews.llvm.org/D35099

Files:
  lld/test/COFF/combined-resources.test
  llvm/include/llvm/Object/COFF.h
  llvm/lib/Object/WindowsResource.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35099.105571.patch
Type: text/x-patch
Size: 16627 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170707/209809e4/attachment.bin>