[PATCH] D35057: [SafepointIRVerifier] Avoid false positives in GC verifier for compare between pointers

[Anna Thomas via Phabricator via llvm-commits]

anna marked an inline comment as done.
anna added a comment.

Need to rebase code over the NFC refactoring.



================
Comment at: lib/IR/SafepointIRVerifier.cpp:230
 static bool
 isExclusivelyConstantDerivedRecursive(const Value *V,
+                                      DenseSet<const Value *> &Visited,
----------------
anna wrote:
> skatkov wrote:
> > Don't you want to re-write this utility function without recursion?
> > In this case you will not need Visited parameter. Also I would suggest this function returns enum BaseType.
> Yeah, that might be better. I'll check it in as NFC, along with the BaseType enum return. We'll still need the visited parameter to avoid traversing through the operands again in the worklist. 
Checked in NFC refactoring change: https://reviews.llvm.org/rL307340


https://reviews.llvm.org/D35057