[PATCH] D35063: [ConstHoisting] Turn on consthoist-with-block-frequency by default

[Wei Mi via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL307338: [ConstHoisting] Turn on consthoist-with-block-frequency by default. (authored by wmi).

Changed prior to commit:
  https://reviews.llvm.org/D35063?vs=105450&id=105563#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D35063

Files:
  llvm/trunk/lib/Transforms/Scalar/ConstantHoisting.cpp
  llvm/trunk/test/Transforms/ConstantHoisting/X86/ehpad.ll


Index: llvm/trunk/test/Transforms/ConstantHoisting/X86/ehpad.ll
===================================================================
--- llvm/trunk/test/Transforms/ConstantHoisting/X86/ehpad.ll
+++ llvm/trunk/test/Transforms/ConstantHoisting/X86/ehpad.ll
@@ -1,9 +1,6 @@
-; RUN: opt -S -consthoist < %s | FileCheck %s
+; RUN: opt -S -consthoist -consthoist-with-block-frequency=false < %s | FileCheck %s
 ; RUN: opt -S -consthoist -consthoist-with-block-frequency=true < %s | FileCheck --check-prefix=BFIHOIST %s
 
-; FIXME: The catchpad doesn't even use the constant, so a better fix would be to
-; insert the bitcast in the catchpad block.
-
 target datalayout = "e-m:w-i64:64-f80:128-n8:16:32:64-S128"
 target triple = "x86_64-pc-windows-msvc"
 
Index: llvm/trunk/lib/Transforms/Scalar/ConstantHoisting.cpp
===================================================================
--- llvm/trunk/lib/Transforms/Scalar/ConstantHoisting.cpp
+++ llvm/trunk/lib/Transforms/Scalar/ConstantHoisting.cpp
@@ -55,7 +55,7 @@
 STATISTIC(NumConstantsRebased, "Number of constants rebased");
 
 static cl::opt<bool> ConstHoistWithBlockFrequency(
-    "consthoist-with-block-frequency", cl::init(false), cl::Hidden,
+    "consthoist-with-block-frequency", cl::init(true), cl::Hidden,
     cl::desc("Enable the use of the block frequency analysis to reduce the "
              "chance to execute const materialization more frequently than "
              "without hoisting."));


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35063.105563.patch
Type: text/x-patch
Size: 1459 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170707/f1f93a00/attachment.bin>