[PATCH] D34841: [lit/libcxx] Fix a remaining reference to lit.util.capture() in custom libcxx/Darwin code.
David L. Jones via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 6 14:47:31 PDT 2017
dlj added a comment.
In https://reviews.llvm.org/D34841#801351, @mzolotukhin wrote:
> > Do you have any hints for how I might be able to tickle the errors you found?
>
> I found this issue in our regular 2 stage PGO build (`generate-profraw` target from `tools/clang/utils/perf-training/CMakeLists.txt` invokes LIT tests). I think we should just replace all appearances of `lit.util.capture` with `subprocess.check_output` - at least, it shouldn't make things worse.
>
> Michael
Works for me. Fixed in r307320.
https://reviews.llvm.org/D34841
More information about the llvm-commits
mailing list