[PATCH] D34697: [ARM] Inline callee if its target-features are a subset of the caller
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 6 13:46:57 PDT 2017
efriedma added inline comments.
================
Comment at: lib/Target/ARM/ARMTargetTransformInfo.cpp:31
+ return CallerBits[ARM::ModeThumb] == CalleeBits[ARM::ModeThumb] &&
+ ((CallerBits & CalleeBits) | ThumbMode) == (CalleeBits | ThumbMode);
+}
----------------
Are you sure ModeThumb is the only feature we need to check for? ModeSoftFloat in particular seems suspicious: VFP intrinsics in the callee could fail to compile. (I'd be much happier if we were whitelisting features; I'm afraid of missing something.)
https://reviews.llvm.org/D34697
More information about the llvm-commits
mailing list