[PATCH] D35027: [PowerPC] Reduce register pressure by not materializing a constant just for use as an index register for X-Form loads/stores
Eric Christopher via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 6 13:44:23 PDT 2017
echristo added a comment.
In https://reviews.llvm.org/D35027#801294, @sfertile wrote:
> Regarding the isIntS16Immediate change, the function is duplicated in PPCISelDAGToDAG.cpp as well. I suggest we leave it as is in this patch, and then in a separate patch common up the definitions and change it to use an int16_t argument. That keeps this patch focused on only doing a single thing, and puts the code cleanup in its own NFC patch.
Feel free to do that first. :)
https://reviews.llvm.org/D35027
More information about the llvm-commits
mailing list