[PATCH] D35037: Bitcode: Include any strings added to the string table in the module hash.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:956
+  if (GenerateHash)
+    Hasher.update(Str);
+  return StrtabBuilder.add(Str);
----------------
pcc wrote:
> tejohnson wrote:
> > Out of curiosity, couldn't the Hasher be updated with the contents of the StrtabBuilder when we writeModuleHash? I guess that would require finalizing the StrtabBuilder a little earlier - ah, we need to add to the StrtabBuilder when building the symtab. 
> > 
> Yes, or when adding other modules to the bitcode file.
Ah, forgot about other modules.


https://reviews.llvm.org/D35037