[PATCH] D34685: Mark a number of x86 only tests to require x86

[Rafael Avila de Espindola via llvm-commits]

It was probably the first email that didn't make it to phab:

-----------------------------------------------------
 On ELF at least you should just use

 REQUIRES: x86

 Do make sure the tests still run when x86 is available :-)
-----------------------------------------------------

Cheers,
Rafael


Paul Robinson via Phabricator via llvm-commits
<llvm-commits at lists.llvm.org> writes:

> probinson added a comment.
>
> In https://reviews.llvm.org/D34685#798776, @JonChesterfield wrote:
>
>> In https://reviews.llvm.org/D34685#796778, @ruiu wrote:
>>
>> > I'm still waiting for you to update this patch to address Rafael's comment.
>>
>>
>> I don't see any comment by Rafael. What are you referring to?
>
>
> Rafael replied via email, not on phabricator, and email replies don't always propagate.  He said:
>
>> davidb added a comment.
>> 
>> In https://reviews.llvm.org/D34685#796778, @ruiu wrote:
>> 
>>> I don't know if I understand what you said correctly. I do not want to force anyone to enable the x86 target. If you disable x86, tests that use x86 as a "generic" target won't run, but it shouldn't be more than that. I'm still waiting for you to update this patch to address Rafael's comment.
>> 
>> I'll update the patch. But I'm still concerned that needing to add "REQUIRES: x86" is going to be an ongoing maintenance for us as new tests are added.
>
> The normal way of avoiding that is setting up a bot. Can you setup one
> that tests lld without the x86 backend?
>
> Cheers,
> Rafael
>
>
> https://reviews.llvm.org/D34685
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits