[LNT] r307222 - Load TestSuite descriptions from json files

[Matthias Braun via llvm-commits]

> On Jul 6, 2017, at 12:44 AM, Kristof Beyls <kristof.beyls at arm.com> wrote:
> 
> 
>> On 6 Jul 2017, at 01:34, Matthias Braun via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>> 
>> Modified: lnt/trunk/requirements.client.txt
>> URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/requirements.client.txt?rev=307222&r1=307221&r2=307222&view=diff <http://llvm.org/viewvc/llvm-project/lnt/trunk/requirements.client.txt?rev=307222&r1=307221&r2=307222&view=diff>
>> ==============================================================================
>> --- lnt/trunk/requirements.client.txt (original)
>> +++ lnt/trunk/requirements.client.txt Wed Jul  5 16:34:37 2017
>> @@ -17,3 +17,4 @@ WTForms==2.0.2
>> Flask-WTF==0.12
>> typing
>> click==6.7
>> +pyyaml==3.12
> 
> I find it odd that this commit adds server functionality, but the pyyaml dependency is added to requirements.client.txt, not requirements.server.txt.
> Should this have been added to requirements.server.txt instead?
> Assuming this really is a bug, it's a shame the regression tests can't easily catch this kind of bug.

This was intentional as it isn't to clear (to me at least) where lnt server ends and lnt client starts:

- `lnt runtest` and `lnt submit` are obviously client and indeed don't need pyyaml
- `lnt runserver` is obviously server
- However there are lots of things like `lnt import`, `lnt checkformat`, `lnt send-daily-report`, `lnt view-comparison` that work with a database instance and hence need to be aware of the schemas. It seems they are considered "client" today or we wouldn't have all those other "server things" like "flask", "sqlalchemy" or "workzeug" in requirements.client.txt. So I figured pyyaml needs to go to requireements.client.txt as well.


If you wonder why yaml: I actually started my work with a json format, which works just as fine. However yaml files tend to look nicer and have 1 killer feature compared to json: They allow to put comments into the file, which I found important enough to warrant a new dependency (yaml also seems to be LLVMs go-to choice for file formats, and tools like the llvm opt-viewer depend on pyyaml as well nowadays).

- Matthias
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170706/51ea0328/attachment.html>