[PATCH] D34602: [GlobalISel][X86] Support call ABI.

Igor Breger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 6 06:25:22 PDT 2017


igorb added inline comments.


================
Comment at: lib/Target/X86/X86CallLowering.cpp:122
+    if (!Info.IsFixed)
+      return true; // TODO: handle variadic function
+
----------------
oren_ben_simhon wrote:
> Since you don't handle variadic functions, an assert should be added before returning true
I need graceful fallback  to DAGSEL in case something not supported yet. Eventually it should be supported.


https://reviews.llvm.org/D34602





More information about the llvm-commits mailing list